Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default umask to restrict permissions on file #196

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

ewjoachim
Copy link
Contributor

Closes #195

Successful PR Checklist:

  • Tests (units, integration, 100% coverage)
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

@ewjoachim ewjoachim requested a review from CorBott as a code owner July 30, 2021 15:37
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #196 (8c781fa) into master (75dcabd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          981       978    -3     
  Branches       130       128    -2     
=========================================
- Hits           981       978    -3     
Impacted Files Coverage Δ
vault_cli/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75dcabd...8c781fa. Read the comment docs.

@ewjoachim ewjoachim enabled auto-merge July 30, 2021 17:23
@ewjoachim ewjoachim merged commit c0d952c into master Jul 30, 2021
@ewjoachim ewjoachim deleted the umask-0600 branch July 30, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default umask should be restrictive
2 participants