Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault-env can write files #186

Merged
merged 5 commits into from
Jul 5, 2021
Merged

Vault-env can write files #186

merged 5 commits into from
Jul 5, 2021

Conversation

ewjoachim
Copy link
Contributor

@ewjoachim ewjoachim commented Feb 8, 2021

Closes #185

Successful PR Checklist:

  • Tests (units, integration, 100% coverage)
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

@ewjoachim ewjoachim requested review from CorBott and mgu as code owners February 8, 2021 09:28
@ewjoachim ewjoachim changed the title TMP Vault-env can write files & templates Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #186 (4e075d4) into master (8505388) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #186   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          970       981   +11     
  Branches       127       130    +3     
=========================================
+ Hits           970       981   +11     
Impacted Files Coverage Δ
vault_cli/cli.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8505388...4e075d4. Read the comment docs.

@ewjoachim ewjoachim marked this pull request as draft February 10, 2021 10:59
vault_cli/cli.py Outdated Show resolved Hide resolved
@ewjoachim ewjoachim changed the base branch from master to refactor-env June 2, 2021 16:09
@ewjoachim ewjoachim changed the title Vault-env can write files & templates Vault-env can write files Jun 2, 2021
@ewjoachim ewjoachim marked this pull request as ready for review June 2, 2021 17:13
Base automatically changed from refactor-env to master June 3, 2021 19:05
@ewjoachim
Copy link
Contributor Author

Thanks @sheb

Only thing left seems:

./vault_cli/cli.py:2:1: F401 'json' imported but unused
./tests/unit/test_cli.py:463:36: F541 f-string is missing placeholders

@ewjoachim
Copy link
Contributor Author

Meanwhile: a mypy update has broken the build :D

Your choice: we can solve this in this PR or in a new PR, it's independant from the modification this PR did bring. I have limited time to take care of this now, but I'll review anything you ping me on :)

vault_cli/cli.py Outdated Show resolved Hide resolved
@ewjoachim ewjoachim merged commit ae87b65 into master Jul 5, 2021
@ewjoachim ewjoachim deleted the env-write-185 branch July 5, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TemporaryFilesystem strategy from SystemD howto doesn't work
2 participants