Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow downloading of ffmpeg/ffprobe if no acceptable executables on path #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

4c0d3r
Copy link

@4c0d3r 4c0d3r commented Dec 28, 2022

This downloads ffmpeg/ffprobe if no acceptable ffmpeg/ffprobe is on the path. By default the download is in the same dir as the executable, but may be overridden with the new command line flag.

@4c0d3r
Copy link
Author

4c0d3r commented Dec 28, 2022

I install ffmpeg even if the command isn't fully provided args to allow namer to leverage video hashes to install ffmpeg as well.

@gedw99
Copy link

gedw99 commented Jan 29, 2023

works on mac intel perfectly :)
I dont have a mac arm64 to test on.

@4c0d3r
Copy link
Author

4c0d3r commented Jan 30, 2023

This has shipped with namer for a while. All Amd64 oses are tested in namer's GitHub actions build. Arm64 likely been tested by someone by now, arm linux, couldn't say.....

@gedw99
Copy link

gedw99 commented Jan 31, 2023

so we can get full testing on all is and chip isa, we could use this approach.

Here’s one of my generic GitHub ci scripts: https://github.com/gedw99/sc-make/blob/main/.github/workflows/ci.yaml

it will cross build and test or anything you want because all it does is call the make file!

makefiles work on windows and Mac and Linux

Here is the make targets: https://github.com/gedw99/sc-make/blob/main/makefile#L17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants