Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: implement no op migration to v0.81.0 #4942

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

cronokirby
Copy link
Contributor

This implements a migration to version 0.81.0, which doesn't require any logic.

This will break PD, but targets the new release branch.

@cronokirby cronokirby added the consensus-breaking breaking change to execution of on-chain data label Nov 22, 2024
@conorsch conorsch self-requested a review November 22, 2024 20:04
@conorsch
Copy link
Contributor

Tested locally by creating a devnet, then:

  1. staking, bonding
  2. proposing upgrade plan
  3. voting
  4. confirming halt
  5. running pd migrate to apply the change: ✔️
  6. confirming chain restarts on new version of pd: ❌ did not work

Step 6 failed because of the version mismatch between pd and local state: we must also increment APP_VERSION in the code so that the startup version check introduced in #4919 is satisfied. I pushed a commit to do just that.

@conorsch conorsch merged commit 2b6503c into release/v0.81.x Nov 22, 2024
12 checks passed
@conorsch conorsch deleted the v0.81.x-no-op-migration branch November 22, 2024 20:57
conorsch added a commit that referenced this pull request Dec 13, 2024
This implements a migration to version 0.81.0, which doesn't require any
logic.

This will break PD, but targets the new release branch. The APP_VERSION has been incremented to 9, in order to satisfy the safeguard version checks from UIP-6.

---------

Co-authored-by: Conor Schaefer <[email protected]>
conorsch added a commit that referenced this pull request Dec 14, 2024
This implements a migration to version 0.81.0, which doesn't require any
logic.

This will break PD, but targets the new release branch. The APP_VERSION has been incremented to 9, in order to satisfy the safeguard version checks from UIP-6.

---------

Co-authored-by: Conor Schaefer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-breaking breaking change to execution of on-chain data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants