UIP-4 Spend Backreferences #4922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
added
the
consensus-breaking
redshiftzero
had a problem deploying
to
smoke-test
GitHub Actions
Failure
|
There's a new branch |
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
redshiftzero
changed the title
redshiftzero
force-pushed
the
uip4-impl
branch
from
c94b30d to
24de4dd
Compare
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
erwanor
reviewed
Nov 15, 2024
cronokirby
reviewed
Nov 15, 2024
| &self, | ||
| brk: &BackreferenceKey, | ||
| nullifier: &Nullifier, | ||
| ) -> Result<Option<Backref>> { |
There was a problem hiding this comment.
I think having Result is smart here, because then you can distinguish between having not put in a back reference, in which case maybe the reference would have pointed to a spend of yours, and a reference you know doesn't belong to you because you can't decrypt it.
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
This is safe because we know the arrays that have been allocated are the correct size
redshiftzero
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
cronokirby
approved these changes
Nov 18, 2024
erwanor
approved these changes
Nov 22, 2024
cronokirby
approved these changes
Nov 22, 2024
conorsch
pushed a commit
that referenced
this pull request
Nov 22, 2024
## Describe your changes This implements UIP-4 as described in penumbra-zone/UIPs#2 ## Issue ticket number and link penumbra-zone/UIPs#2 ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
conorsch
pushed a commit
that referenced
this pull request
Dec 13, 2024
## Describe your changes This implements UIP-4 as described in penumbra-zone/UIPs#2 ## Issue ticket number and link penumbra-zone/UIPs#2 ## Checklist before requesting a review - [ ] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
conorsch
pushed a commit
that referenced
this pull request
Dec 14, 2024
This implements UIP-4 as described in penumbra-zone/UIPs#2 penumbra-zone/UIPs#2 - [ ] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This implements UIP-4 as described in penumbra-zone/UIPs#2
Issue ticket number and link
penumbra-zone/UIPs#2
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: