Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.80.9, via point-release #4928

Closed
4 tasks
conorsch opened this issue Nov 18, 2024 · 3 comments
Closed
4 tasks

Release v0.80.9, via point-release #4928

conorsch opened this issue Nov 18, 2024 · 3 comments
Assignees

Comments

@conorsch
Copy link
Contributor

Tooling Release

In order to ship some minor improvements and bug fixes, let's prepare a v0.80.9 release, flushing out the current contents of the main branch.

Changes to include

Compatibility

As this is a point-release, all changes must be fully compatible for all nodes and clients.
Careful attention should be given to the delta between most recent tag on the main branch:
https://github.com/penumbra-zone/penumbra/compare/v0.80.8..main

@conorsch conorsch self-assigned this Nov 18, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Nov 18, 2024
@conorsch conorsch removed the needs-refinement unclear, incomplete, or stub issue that needs work label Nov 18, 2024
@conorsch
Copy link
Contributor Author

Delaying release slightly due to a tooling error: running cargo release 0.80.9 --execute yields a commit message that doesn't interpolate the version string as usual:

chore: release version {{version}}

Worked fine for 0.80.8, so I'm not sure what changed. Will debug and follow up to unblock.

@conorsch
Copy link
Contributor Author

Quickly isolated the changes in #4930 as causing the problem: if I revert just the single commit from #4930, then the tool works correctly, and the version number is interpolated. Took longer to figure out just why that was, though. There are some discrepancies in the parameter-setup crate's Cargo.toml when compared against other crates, mostly omitted metadata like authors, homepage, license, and repository. Setting those doesn't resolve the problem, but what did resolve the problem was setting version = { workspace = true }.

conorsch added a commit that referenced this issue Nov 21, 2024
Updates the package metadata for the `parameter-setup` crate,
which was recently pulled into the workspace. Without these changes,
`cargo-release` was failing to add a version number to the automatically
generated commit message.

Refs #4928, #4930.
conorsch added a commit that referenced this issue Nov 21, 2024
## Describe your changes

Updates the package metadata for the `parameter-setup` crate, which was
recently pulled into the workspace. Without these changes,
`cargo-release` was failing to add a version number to the automatically
generated commit message.



## Issue ticket number and link

Refs #4928, #4930.

## Testing and review

If you care to verify the results locally, you can:

```
git checkout -b my-feature-branch
cargo release 0.80.9 --execute # this won't push anything, but will require cleanup
git show # to view the commit message
```

Make sure that the generated commit message says "chore: release version
0.80.9", _not_ "chore: release version {{version}}". If you ran these
steps, **you must clean up**:

```
git checkout main
git tag -d v0.80.9
git branch -D my-feature-branch
```

If you forget to delete the tag, then when 0.80.9 is actually released,
you won't be able to pull the tag from github.

## Checklist before requesting a review

- [x] I have added guiding text to explain how a reviewer should test
these changes.

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > package metadata only, no changes to application code
@conorsch
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant