-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMCS-5353 - Update QAT tests #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!! 👏
.github/workflows/qat.yml
Outdated
nvm install | ||
nvm use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick (install will install and use, or just use if it's already installed)
nvm install | |
nvm use | |
nvm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
3b50291
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
This PR updates GH actions for QAT tests
Summary
npm run qat
is available in repoSITE_URL
andTHEME_NAME
Sample run (for sourcingjournal) - Raw log
https://github.com/penske-media-corp/pmc-sourcingjournal-2021/actions/runs/3969993790/jobs/6805188785
Steps:
penske-media-corp/github-action-wordpress-test-setup@main
with nodejs enablednpm run qa:debug
exists in package.jsonRUN_QAT=true
orRUN_QAT=false
in env. The rest of steps are skipped if its value is false. (it won't run qat tests)npm ci
andnpx playwright install --with-deps
Bash script used for BitBucket & SJ
(I used and converted this code to GH actions)