Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Dev Dockerfile, Update README, Relock Pipfile, Add psql to Dev Container #679

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

shiva-menta
Copy link
Contributor

@shiva-menta shiva-menta commented Oct 22, 2024

Various environment changes to reflect the current state of PCX backend:

  • Deprecating Dev Dockerfile – Abandoning this in favor of developing in Dev Containers. Old Dockerfile.dev also was pinned to an old version of Python.
  • Updating README – Removing instructions related to Dockerfile.dev, adding Dev Container-specific instructions, and cleaning up the content a bit.
  • Relocking Pipfile – Resolving lingering versioning issues when running the backend for the first time.
  • Add psql to Dev Container – We previously didn't install postgresql-client within the Dev Container, but this is needed for loading PCX data into database. Based on Dev Container ubuntu version, psql is outdated at version 14 compared to new pinned version of postgres at version 15.8 (closest version to our current prod database), but this should be okay.

Copy link
Contributor

@el-agua el-agua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shiva-menta shiva-menta merged commit 77bb898 into master Oct 25, 2024
13 checks passed
@shiva-menta shiva-menta deleted the deprecate_dev_dockerfile branch October 25, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants