Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicating PCP Course Meetings w/ Conflicting Times / Locations #678

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

shiva-menta
Copy link
Contributor

@shiva-menta shiva-menta commented Oct 22, 2024

We found a Path@Penn error for CIS 4480 in which there are multiple listings for the same exact time slots, all with different locations. While this will likely be resolved soon, this PR adds a quick fix to list only one of the locations on PCP if there are multiple conflicting meetings with different locations. This is a FRONTEND only change.

Before
Screenshot 2024-10-21 at 8 19 19 PM
Screenshot 2024-10-21 at 8 20 40 PM

After
Screenshot 2024-10-21 at 8 20 55 PM
Screenshot 2024-10-21 at 8 19 29 PM

Copy link
Contributor

@Clue88 Clue88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks shiva

@shiva-menta shiva-menta merged commit ca1f19f into master Oct 22, 2024
13 checks passed
@shiva-menta shiva-menta deleted the handle_path_duplicates_frontend branch October 22, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants