Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Review Data Parsing Scripts #676

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

shiva-menta
Copy link
Contributor

While uploading the review data from semesters 2024A/B, I ran into a few errors due to some new formatting. The changes are summarized below:

  • Summary Rows can have some null values for keys such as RWORKREQUIRED. When we create ReviewBit objects, we want to ensure that there is at least some data present that we are saving. The assumption is that if we are not given a value for these fields in the summary dump, there are no values to be saved.
  • Ratings Rows also now have some null values for keys. Our previously logic was checking if val is None, but our parser is not catching these values, so we want to also check for the string "null".
  • Date information from this dump came in a new format, DD-MON-RR, which required parser support. The RR year format isn't supported directly through Python's datetime module, so we added an additional function to find the four digit year it corresponds with. More information on this conversion here.

Copy link
Contributor

@el-agua el-agua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shiva-menta shiva-menta merged commit 5823e50 into master Oct 17, 2024
13 checks passed
@shiva-menta shiva-menta deleted the update_iscimport_2024 branch October 17, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants