-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCS front+back #487
base: master
Are you sure you want to change the base?
PCS front+back #487
Conversation
AaDalal
commented
Apr 15, 2023
- fix accordion arrow not showing up
- mobile view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the changes to
k8s/*
- the thing I mentioned above about calling
dump_redis_data
regularly- making sure that our redis cluster will stay up and preserve state between when we call
dump_redis_data
(platform needs to guarantee this)
- Frontend is still a mystery 😨
- We need to lint :)
- Happy to call to go over this stuff (I can also help fix anything if needed)
) | ||
avg_reviews = reviewed_course["average_reviews"] | ||
yield { | ||
"code": course.full_code.replace("-", " "), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason that we replace the dashes? Does redisearch not do stemming unless we do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohangpta or @rm03 do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, my guess is as good as yours. @rm03?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also unsure - RediSearch won't stem that field as specified in the schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should stem that field. It's pretty bad at matching course codes rn :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some more clarifications
id__in=Subquery(Section.objects.filter(section_filters_pcr).values("instructors__id")) | ||
) | ||
.distinct()[:100] | ||
.values("name", "id", "section__course__department__code") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ There can be more than 1 associated section, but you can use section
to get all of them (like section_set
). For some reason we named it section
not section_set