PCS front+back #487
PCS front+back #487
Conversation
AaDalal
commented
Apr 15, 2023
AaDalal
commented
- fix accordion arrow not showing up
- mobile view
There was a problem hiding this comment.
- the changes to
k8s/*- the thing I mentioned above about calling
dump_redis_dataregularly- making sure that our redis cluster will stay up and preserve state between when we call
dump_redis_data(platform needs to guarantee this)
- Frontend is still a mystery 😨
- We need to lint :)
- Happy to call to go over this stuff (I can also help fix anything if needed)
| ) | ||
| avg_reviews = reviewed_course["average_reviews"] | ||
| yield { | ||
| "code": course.full_code.replace("-", " "), |
There was a problem hiding this comment.
is there a reason that we replace the dashes? Does redisearch not do stemming unless we do?
There was a problem hiding this comment.
@rohangpta or @rm03 do you know?
There was a problem hiding this comment.
Not sure, my guess is as good as yours. @rm03?
There was a problem hiding this comment.
Also unsure - RediSearch won't stem that field as specified in the schema
There was a problem hiding this comment.
I think we should stem that field. It's pretty bad at matching course codes rn :/
| id__in=Subquery(Section.objects.filter(section_filters_pcr).values("instructors__id")) | ||
| ) | ||
| .distinct()[:100] | ||
| .values("name", "id", "section__course__department__code") |
There was a problem hiding this comment.
^^ There can be more than 1 associated section, but you can use section to get all of them (like section_set). For some reason we named it section not section_set
