Cleaner init for GitHubFetcher in app

pengwynn · Dec 9, 2014 · e3c9653 · e3c9653
1 parent e35708a
commit e3c9653
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/flint/app.go b/flint/app.go
@@ -2,7 +2,6 @@ package flint
 
 import (
 	"github.com/codegangsta/cli"
-	"github.com/octokit/go-octokit/octokit"
 
 	"fmt"
 	"os"
@@ -98,14 +97,10 @@ func newFlagsFromContext(c *cli.Context) *Flags {
 }
 
 var newGitHubFetcher = func(c *cli.Context) RemoteRepositoryFetcher {
-	var client *octokit.Client
-
 	token := c.String("token")
 	if len(token) > 0 {
-		client = octokit.NewClient(octokit.TokenAuth{AccessToken: token})
+		return NewGitHubFetcherWithToken(token)
 	} else {
-		client = octokit.NewClient(nil)
+		return NewGitHubFetcher()
 	}
-
-	return &GitHubFetcher{client}
 }
diff --git a/flint/github_fetcher.go b/flint/github_fetcher.go
@@ -76,6 +76,12 @@ func (g *GitHubFetcher) ParseFullName(nwo string) (owner, name string, err error
 	return
 }
 
+func NewGitHubFetcher() *GitHubFetcher {
+	client := octokit.NewClient(nil)
+
+	return &GitHubFetcher{&*client}
+}
+
 func NewGitHubFetcherWithToken(token string) *GitHubFetcher {
 	client := octokit.NewClient(&octokit.TokenAuth{AccessToken: token})