Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure export file path always contains a valid file name extension #1736

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

J5lx
Copy link
Member

@J5lx J5lx commented Oct 30, 2022

On Windows, it is possible to select an export file path with an invalid file name extension by manually typing the name of a pre-existing file into the text field. That will then confuse the movie exporter because it doesn’t know how to handle the unknown extension, as seen in this forum thread. To avoid this, it is necessary to manually check the extension of the selected file path.

Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, however this PR will clash with #1657

So i'm not sure whether we should wait with merging till the other one is done, what do you think?

@J5lx
Copy link
Member Author

J5lx commented Oct 30, 2022

Argh you’re right I completely forgot about that one. I’ll take another look to see what’s needed for that one to move forward.

@J5lx J5lx merged commit 9a5dd51 into pencil2d:master Oct 30, 2022
@J5lx J5lx deleted the fixes/export-suffix branch October 30, 2022 23:10
@MrStevns MrStevns added this to the v0.6.7 milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants