Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyframe undo that would cause crash or double undo in some cases (issue #1557) #1629

Merged
merged 1 commit into from
Apr 18, 2021

Conversation

aeroc7
Copy link
Contributor

@aeroc7 aeroc7 commented Apr 16, 2021

Add boolean return value on backup function so that we can check if the backup was actually successful.

Fixes #1557

@MrStevns
Copy link
Member

Hi @aeroc7

Thanks for your contribution! The code looks good to me, so let's just get it in.
There's a larger rework of undo/redo in the works which was started by me, but until that gets done, I think it's a good idea to fix the bugs we can with the current one we have.

Merging 👍

Copy link
Member

@MrStevns MrStevns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrStevns MrStevns merged commit 2935790 into pencil2d:master Apr 18, 2021
@scribblemaniac
Copy link
Member

Thanks for the contribution and welcome!

@MrStevns MrStevns mentioned this pull request May 4, 2021
@chchwy chchwy added this to the 0.7.0 milestone Jul 15, 2021
@MrStevns MrStevns modified the milestones: 0.7.0, v0.6.7 Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undo frame deletion double undo/crash
4 participants