Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pen dabs are being added on top of each other #1799

Closed
MrStevns opened this issue Dec 3, 2023 · 3 comments · Fixed by #1800
Closed

Pen dabs are being added on top of each other #1799

MrStevns opened this issue Dec 3, 2023 · 3 comments · Fixed by #1800
Assignees
@MrStevns
Labels
Bug Regression
Milestone
0.7.0

Comments

@MrStevns
Copy link
Member

MrStevns commented Dec 3, 2023 •
edited
Loading

Issue Summary

Actual Results

Expected Results

The pen dabs should merge, so they are not seen individually

Video or Image Reference

pen-dab-stable

The video first shows the stroke in 0.6.6 stable and then switches to our nightly build

Steps to reproduce

  • Select pen tool
  • Draw a stroke with 30% alpha

System Information

  • Pencil2D Version:
    Nightly Build Oct 17 2023

commit: 127cd62
date: 2023-10-17_21:30:25

Operating System: macOS 12.6
CPU Architecture: x86_64
Qt Version: 5.15.10
@MrStevns MrStevns added this to the v0.6.7 milestone Dec 3, 2023
@MrStevns MrStevns self-assigned this Dec 3, 2023
@J5lx
Copy link
Member

J5lx commented Dec 3, 2023

@MrStevns This appears to have been introduced in #1776. (I was in the process of doing a bisect while you opened the report). I see you already assigned yourself, so I’ll leave the rest to you.

@MrStevns MrStevns mentioned this issue Dec 3, 2023
Merged
MrStevns added a commit to MrStevns/pencil that referenced this issue Dec 3, 2023
@MrStevns
Regression - pencil2d#1799: Fix pen dabs being added to each other
4dbd2bc
@MrStevns
Copy link
Member Author

MrStevns commented Dec 3, 2023

Yeah I figured as much, considering I've been the most recent one making changes around those parts 😅

@J5lx
Copy link
Member

J5lx commented Dec 3, 2023

Oh I wish I was better at remembering stuff like that from the top of my head

MrStevns added a commit to MrStevns/pencil that referenced this issue Dec 3, 2023
@MrStevns
Regression - pencil2d#1799: Fix pen dabs being added to each other
8baa511
MrStevns added a commit to MrStevns/pencil that referenced this issue Dec 10, 2023
@MrStevns
Regression - pencil2d#1799: Fix pen dabs being added to each other
061e085 
Actually the first check in canvas painter would always return true because the blitRect and mTilledBuffer rect are in different coordinate spaces.
J5lx pushed a commit that referenced this issue Dec 10, 2023
@MrStevns
Regression - #1799: Fix pen dabs being added to each other (#1800)
363dcd7 
Actually the first check in canvas painter would always return true because the blitRect and mTilledBuffer rect are in different coordinate spaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrStevns MrStevns

Labels
Bug Regression
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Regression - #1799: Fix pen dabs being added to each other MrStevns/pencil
2 participants
@MrStevns @J5lx