Fix serial type decoding for BLOB and TEXT #264
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
>
with>=
to match the SQLite documentation. Serial type value12
is for 0-size BLOB, and13
is for 0-size TEXT.Should I have filed a separate bug ticket? This seemed easy to fix straight away.
Should I add more test cases? Anyway it looks like
testing.db
doesn't have empty strings - or blobs at all.