Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date and time code cleanups #261

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Date and time code cleanups #261

merged 5 commits into from
Aug 2, 2024

Commits on Aug 2, 2024

  1. core/datetime: Remove trace calls 

    We should trace in high-level code like VDBE interpreter loop, but not
in error handling path of specific SQL functions.
    @penberg
    penberg committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    83955b7 View commit details
    Browse the repository at this point in the history

  2. core/datetime: Use "cfg(test)" annotation for tests

    @penberg
    penberg committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4303664 View commit details
    Browse the repository at this point in the history

  3. core/datetime: Remove TimeUnit 

    ...it's not used for anything much.
    @penberg
    penberg committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8621ebd View commit details
    Browse the repository at this point in the history

  4. core/datetime: Simplify error handling

    @penberg
    penberg committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    68a135e View commit details
    Browse the repository at this point in the history

  5. core/datetime: Move get_max_datetime_exclusive() to bottom 

    Move the function so that it's callers are above the function definition
for smoother flow when reading the code.
    @penberg
    penberg committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    72f8ac2 View commit details
    Browse the repository at this point in the history