Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException when no probability is computed #63

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

fsonntag
Copy link

@fsonntag fsonntag commented Jul 3, 2020

Fixing a NullPointerException. Maybe there's a more in-depth problem, but from my perception this seems like the most realistic solution.

I'm also not sure to which branch this should be merged, as this is more a hotfix, which should go into master and 1.1.0.

Repository owner deleted a comment from codecov-commenter Jul 3, 2020
@pemistahl pemistahl changed the base branch from master to v1.0.1-bugfix July 3, 2020 15:16
@pemistahl pemistahl added the bug Something isn't working label Jul 3, 2020
@pemistahl
Copy link
Owner

Good catch @fsonntag. How could I miss that one? Annoying!

Anyway, thanks a lot for fixing it! This will go into version 1.0.1 which I will release shortly.

@pemistahl pemistahl merged commit 6f613a3 into pemistahl:v1.0.1-bugfix Jul 3, 2020
@pemistahl pemistahl changed the title Fixed computing language confidence values when no probability is computed Fix NullPointerException when no probability is computed Jul 3, 2020
@fsonntag
Copy link
Author

fsonntag commented Jul 3, 2020

Thanks a lot for following up on this so quickly!

@pemistahl pemistahl added this to the Lingua 1.0.1 milestone Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants