Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish is not included in the list of valid languages for acute-accented characters #73

Closed
joeporter opened this issue Sep 24, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@joeporter
Copy link

"ÁáÍíÚú" to setOf(CATALAN, CZECH, ICELANDIC, IRISH, HUNGARIAN, PORTUGUESE, SLOVAK, VIETNAMESE, YORUBA),

Currently "Como estas" returns SPANISH while "Cómo estás" returns PORTUGUESE. Digging further I realized that Spanish was missing from the set of allowed languages for many of the Spanish accented characters:

á = ‘ + a
é = ‘ + e
í = ‘ + i
ó = ‘ + o
ú = ‘ + u
ñ = ~ + n (this one is ok)
ü = ” + u

@pemistahl
Copy link
Owner

Hi @joeporter, thanks for reporting this issue. Indeed, somehow I missed to consider Spanish for these accented characters. That was probably because these accents are only used if the default stress rules cannot be applied to a Spanish word. Therefore these accents are somewhat rare in Spanish, so I forgot to add them. I will fix that.

@pemistahl pemistahl added the bug Something isn't working label Oct 2, 2020
@pemistahl pemistahl modified the milestones: Lingua 1.1.0, Lingua 1.0.3 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants