feat: annotation comment on struct #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yvonnick Esnault <[email protected]>
yesnault
force-pushed
the
ye-commment
branch
from
117a8c2 to
c58d639
Compare
Signed-off-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Yvonnick Esnault <[email protected]>
yesnault
force-pushed
the
ye-commment
branch
from
a2fe53c to
e47763c
Compare
Signed-off-by: Yvonnick Esnault <[email protected]>
Signed-off-by: Yvonnick Esnault <[email protected]>
|
Very nice. Thank you very much for your contribution! |
|
I was just thinking about adding this feature (for golang/dep#1224)! Thanks for doing so. It is somewhat awkward to write long comments on a struct tag, and impossible to include dynamic comments this way. Another alternative would have been to make Comment and Commented be methods that a type (for the field itself, not the surrounding type) to implement, discoverable via reflection. |
|
@glasser Sorry I missed your comment! Would you mind writing a code sample of how that feature would be used? |
pelletier
added a commit
that referenced
this pull request
Jan 18, 2018
Patch #185 introduced a backward incompatibility by changing the arguments of the `Set*` methods on `Tree`. This change restores the arguments to what they previous were, and introduces `SetWithComment` and `SetPathWithComment` to perform the same action.
pelletier
added a commit
that referenced
this pull request
Jan 18, 2018
Patch #185 introduced a backward incompatibility by changing the arguments of the `Set*` methods on `Tree`. This change restores the arguments to what they previous were, and introduces `SetWithComment` and `SetPathWithComment` to perform the same action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TestMarshalComment.
close #184