spiffs_object_read() read past end of file

[apwise]

In spiffs_object_read(), there's code to compute how much data can be read in each "chunk":

spiffs/src/spiffs_nucleus.c

Lines 2028 to 2033 in 1350deb

	// all remaining data
	u32_t len_to_read = offset + len - cur_offset;
	// remaining data in page
	len_to_read = MIN(len_to_read, SPIFFS_DATA_PAGE_SIZE(fs) - (cur_offset % SPIFFS_DATA_PAGE_SIZE(fs)));
	// remaining data in file
	len_to_read = MIN(len_to_read, fd->size);

surely the last of the tests above should be:
len_to_read = MIN(len_to_read, (fd->size - cur_offset));

as it should be testing how much data remains in the file to be read, not the total file size?

[pellepl]

Yeah, makes sense. I'll look it over. Good catch! Den sön 24 mars 2019 09:17Adrian Wise <[email protected]> skrev:

…

In spiffs_object_read(), there's code to compute how much data can be read in each "chunk": https://github.com/pellepl/spiffs/blob/1350deb54c097fd06133f3c6d39dd3532a229829/src/spiffs_nucleus.c#L2028-L2033 surely the last of the tests above should be: len_to_read = MIN(len_to_read, (fd->size - cur_offset)); as it should be testing how much data remains in the file to be read, not the total file size? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#237>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AE3NVyXt4QoGC2D5OruvHOs_jy69IGoSks5vZzSBgaJpZM4cFX4x> .

[pellepl]

@apwise: thanks!