Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Update egg-palworld.json for RCON cli #2771

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

DylanDelobel
Copy link
Contributor

@DylanDelobel DylanDelobel commented Feb 27, 2024

Description

Following this issue thijsvanloef/palworld-server-docker#458

From the update for v0.1.5.0 the -rcon argument is needed

This is a quick fix for people who had scheduled auto-reboot from the CLI

Ps: without this, my server was in a bad state, and auto-restart from Ptero was not working, will work on optional on/off rcon, public server on/off and other new changes from the update later this weekend :)

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

@DylanDelobel
Copy link
Contributor Author

Asking for review 🙏

@QuintenQVD0 @Ballaual

@Ballaual
Copy link
Contributor

for me this is ok.

before egg update:
image

after egg update:
image

The config parser also needs an update as there is a new command available.
@QuintenQVD0 i'll pr the changes on your repo.

@QuintenQVD0
Copy link
Collaborator

If this egg can be re-exported from a panel then this can be merged. I need to append the parser update to this still.

@DylanDelobel
Copy link
Contributor Author

@QuintenQVD0 I exported the egg from my panel, and pushed the whole file 👍
image

@Ballaual
Copy link
Contributor

you messed sth up with the -rcon in your panel at the end ^^ The quotes from the ADMIN_PASSWORD are now at the wrong place ;) take this and upload re-push it. This is already fixed :)
egg-palworld.json

@QuintenQVD0
Copy link
Collaborator

There is a reason it is not allowed to edit the .json file directly.

@DylanDelobel
Copy link
Contributor Author

@Ballaual @QuintenQVD0
Sorry for my mistakes 😢

There is a reason it is not allowed to edit the .json file directly

There a way to "generate" this Startup command from Variables tabs ?

@Ballaual
Copy link
Contributor

Ballaual commented Feb 27, 2024

@Ballaual @QuintenQVD0 Sorry for my mistakes 😢

There is a reason it is not allowed to edit the .json file directly

There a way to "generate" this Startup command from Variables tabs ?

wdym? Everything you change on an egg just need to be edit in the panel (startup/variables/install etc.) and then be exported from there.
No need to touch the json file by hand.

@pedrotski
Copy link
Contributor

Tbh you can actually set -RCONPort=xxxxx directly from the startup command now so the parser is no longer needed. You can also set other things such as admin password, game password from the startup command, and it will override whatever is in your .ini file.

It might be worth doing an overhaul and simplifying the egg now.

@QuintenQVD0
Copy link
Collaborator

@DylanDelobel Wy did the keyword pal got removed after the binary name?

@DylanDelobel
Copy link
Contributor Author

DylanDelobel commented Feb 27, 2024

@DylanDelobel Wy did the keyword pal got removed after the binary name?

@Ballaual Told me this was an error #2771 (comment)

@Ballaual
Copy link
Contributor

Ballaual commented Feb 27, 2024

@DylanDelobel Wy did the keyword pal got removed after the binary name?

it's not necessary or did i mistake here? then sorry..
at least i cant find it anywhere in the actual docs

@QuintenQVD0
Copy link
Collaborator

@DylanDelobel Wy did the keyword pal got removed after the binary name?

it's not necessary or did i mistake here? then sorry.. at least i cant find it anywhere in the actual docs

is it still in there .sh file? if so then we keep it there

@Ballaual
Copy link
Contributor

Ballaual commented Feb 27, 2024

@DylanDelobel Wy did the keyword pal got removed after the binary name?

it's not necessary or did i mistake here? then sorry.. at least i cant find it anywhere in the actual docs

is it still in there .sh file? if so then we keep it there

let me check quick

yea... it is still there even it does not change anything as i already tested the version

image

@QuintenQVD0
Copy link
Collaborator

@DylanDelobel Wy did the keyword pal got removed after the binary name?

it's not necessary or did i mistake here? then sorry.. at least i cant find it anywhere in the actual docs

is it still in there .sh file? if so then we keep it there

let me check quick

yea... it is still there even it does not change anything as i already tested the version

image

I will just keep it here to be certain?

@Ballaual
Copy link
Contributor

@QuintenQVD0 dont forget to update the naming of the parser in the startup ;)

@QuintenQVD0
Copy link
Collaborator

QuintenQVD0 commented Feb 27, 2024

@QuintenQVD0 dont forget to update the naming of the parser in the startup ;)

Nothing renamed?

if you are talking about curl -sSL -o PalworldServerConfigParser https://raw.githubusercontent.com/parkervcp/eggs/master/game_eggs/steamcmd_servers/palworld/PalworldServerConfigParser-linux-amd64

we write it as a cut of filename

@Ballaual
Copy link
Contributor

@QuintenQVD0 dont forget to update the naming of the parser in the startup ;)

Nothing renamed?

if you are talking about curl -sSL -o PalworldServerConfigParser https://raw.githubusercontent.com/parkervcp/eggs/master/game_eggs/steamcmd_servers/palworld/PalworldServerConfigParser-linux-amd64

we write it as a cut of filename

i see!

@QuintenQVD0
Copy link
Collaborator

@QuintenQVD0 dont forget to update the naming of the parser in the startup ;)

Nothing renamed?
if you are talking about curl -sSL -o PalworldServerConfigParser https://raw.githubusercontent.com/parkervcp/eggs/master/game_eggs/steamcmd_servers/palworld/PalworldServerConfigParser-linux-amd64
we write it as a cut of filename

i see!

you tested the 1.0.11 one? (should still work as the 1.0.10 worked and this change is so litte)

@Ballaual
Copy link
Contributor

@QuintenQVD0 dont forget to update the naming of the parser in the startup ;)

Nothing renamed?
if you are talking about curl -sSL -o PalworldServerConfigParser https://raw.githubusercontent.com/parkervcp/eggs/master/game_eggs/steamcmd_servers/palworld/PalworldServerConfigParser-linux-amd64
we write it as a cut of filename

i see!

you tested the 1.0.11 one? (should still work as the 1.0.10 worked and this change is so litte)

currently testing, need to add a ptero variable first

Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuintenQVD0
Copy link
Collaborator

@Ballaual Let me know, in my testing it works.

@pedrotski
Copy link
Contributor

@QuintenQVD0 why even use the parser still? -rcon or -RCONEnable=true is not required as long as you simply use -RCONPort=xxxxx in the startup command.

@Ballaual
Copy link
Contributor

@Ballaual Let me know, in my testing it works.

for me it gives this console output.
Updating key: bShowPlayerList with value: True
Key not found: bShowPlayerList

As i wrote in the pr the variable has been added to the game but not to the example config.
The parser is not able to put in the value if its not exist.

@QuintenQVD0
Copy link
Collaborator

@QuintenQVD0 why even use the parser still? -rcon or -RCONEnable=true is not required as long as you simply use -RCONPort=xxxxx in the startup command.

The parser can do way more then the variables you see, it handles now PUBLIC_IP variable so if your allocation is public you can leave it empty and it will take the allocate ip, and it also allows you to edit all other variables in the config. Those are not default setup but you can if you want a more easy way to edit some config values

@QuintenQVD0
Copy link
Collaborator

@Ballaual Let me know, in my testing it works.

for me it gives this console output. Updating key: bShowPlayerList with value: True Key not found: bShowPlayerList

As i wrote in the pr the variable has been added to the game but not to the example config. The parser is not able to put in the value if its not exist.

wait they did not add that to the DefaultPalWorldSettings.ini ?

@Ballaual
Copy link
Contributor

wait they did not add that to the DefaultPalWorldSettings.ini ?

Nope... idk why they add a new config entry but not updating their config example..
But i also wrote that over there.
I just re-downloaded the DefaultPalWorldSettings.ini to verify this.

@QuintenQVD0
Copy link
Collaborator

wait they did not add that to the DefaultPalWorldSettings.ini ?

Nope... idk why they add a new config entry but not updating their config example.. But i also wrote that over there. I just re-downloaded the DefaultPalWorldSettings.ini to verify this.

I guess just add a note to the readme here that it has to be done?

@Ballaual
Copy link
Contributor

Ballaual commented Feb 27, 2024

wait they did not add that to the DefaultPalWorldSettings.ini ?

Nope... idk why they add a new config entry but not updating their config example.. But i also wrote that over there. I just re-downloaded the DefaultPalWorldSettings.ini to verify this.

I guess just add a note to the readme here that it has to be done?

either this or can u somehow update the parser to handle this? add string at the end of the config before the the closing bracket.
i guess they might add more variables over time and if they miss to add this to their config file you will always have this problem?

@QuintenQVD0
Copy link
Collaborator

wait they did not add that to the DefaultPalWorldSettings.ini ?

Nope... idk why they add a new config entry but not updating their config example.. But i also wrote that over there. I just re-downloaded the DefaultPalWorldSettings.ini to verify this.

I guess just add a note to the readme here that it has to be done?

either this or can u somehow update the parser to handle this? add string at the end of the config before the the closing bracket. i guess they might add more variables over time and if they miss to add this to their config file you will always have this problem?

To be honnest then I prefer thay they do it theirself as if things change and the parser makes the config invalid I am the one they will blame

@Ballaual
Copy link
Contributor

wait they did not add that to the DefaultPalWorldSettings.ini ?

Nope... idk why they add a new config entry but not updating their config example.. But i also wrote that over there. I just re-downloaded the DefaultPalWorldSettings.ini to verify this.

I guess just add a note to the readme here that it has to be done?

either this or can u somehow update the parser to handle this? add string at the end of the config before the the closing bracket. i guess they might add more variables over time and if they miss to add this to their config file you will always have this problem?

To be honnest then I prefer thay they do it theirself as if things change and the parser makes the config invalid I am the one they will blame

currently the rest of the config just works and gets updated correctly and the parser dont touch anything thats not exists.

@QuintenQVD0 QuintenQVD0 merged commit 074c786 into pelican-eggs:master Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants