-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update egg-palworld.json for RCON cli #2771
Conversation
Asking for review 🙏 |
for me this is ok. The config parser also needs an update as there is a new command available. |
If this egg can be re-exported from a panel then this can be merged. I need to append the parser update to this still. |
@QuintenQVD0 I exported the egg from my panel, and pushed the whole file 👍 |
you messed sth up with the -rcon in your panel at the end ^^ The quotes from the ADMIN_PASSWORD are now at the wrong place ;) take this and upload re-push it. This is already fixed :) |
There is a reason it is not allowed to edit the .json file directly. |
@Ballaual @QuintenQVD0
There a way to "generate" this Startup command from Variables tabs ? |
wdym? Everything you change on an egg just need to be edit in the panel (startup/variables/install etc.) and then be exported from there. |
Tbh you can actually set -RCONPort=xxxxx directly from the startup command now so the parser is no longer needed. You can also set other things such as admin password, game password from the startup command, and it will override whatever is in your .ini file. It might be worth doing an overhaul and simplifying the egg now. |
@DylanDelobel Wy did the keyword pal got removed after the binary name? |
@Ballaual Told me this was an error #2771 (comment) |
it's not necessary or did i mistake here? then sorry.. |
… the parser takes care of that
is it still in there .sh file? if so then we keep it there |
let me check quick yea... it is still there even it does not change anything as i already tested the version |
I will just keep it here to be certain? |
@QuintenQVD0 dont forget to update the naming of the parser in the startup ;) |
Nothing renamed? if you are talking about we write it as a cut of filename |
i see! |
you tested the 1.0.11 one? (should still work as the 1.0.10 worked and this change is so litte) |
currently testing, need to add a ptero variable first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Ballaual Let me know, in my testing it works. |
@QuintenQVD0 why even use the parser still? -rcon or -RCONEnable=true is not required as long as you simply use -RCONPort=xxxxx in the startup command. |
for me it gives this console output. As i wrote in the pr the variable has been added to the game but not to the example config. |
The parser can do way more then the variables you see, it handles now PUBLIC_IP variable so if your allocation is public you can leave it empty and it will take the allocate ip, and it also allows you to edit all other variables in the config. Those are not default setup but you can if you want a more easy way to edit some config values |
wait they did not add that to the |
Nope... idk why they add a new config entry but not updating their config example.. |
I guess just add a note to the readme here that it has to be done? |
either this or can u somehow update the parser to handle this? add string at the end of the config before the the closing bracket. |
To be honnest then I prefer thay they do it theirself as if things change and the parser makes the config invalid I am the one they will blame |
currently the rest of the config just works and gets updated correctly and the parser dont touch anything thats not exists. |
Description
Following this issue thijsvanloef/palworld-server-docker#458
From the update for v0.1.5.0 the
-rcon
argument is neededThis is a quick fix for people who had scheduled auto-reboot from the CLI
Ps: without this, my server was in a bad state, and auto-restart from Ptero was not working, will work on optional on/off rcon, public server on/off and other new changes from the update later this weekend :)
Checklist for all submissions