Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

BattleBit Remastered egg #2514

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Destructor
Copy link

@Destructor Destructor commented Oct 18, 2023

Description

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?
    • If not, why?:
  • You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  • The egg was exported from the panel

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@QuintenQVD0
Copy link
Collaborator

This is just a modified version of my dotnet generic egg. So in no way is this an egg for https://store.steampowered.com/app/671860/BattleBit_Remastered/ . You just changed the owner? and the title?

Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start again from 0 as this is just my modified C# egg and in no way this is a generic egg

@QuintenQVD0 QuintenQVD0 marked this pull request as draft October 19, 2023 07:54
@Rephot
Copy link

Rephot commented Mar 18, 2024

Please start again from 0 as this is just my modified C# egg and in no way this is a generic egg

The pull request is fine - theres 2 eggs, A bespoke one for the battlebit server and a modified c# one used for running BattleBitAPIRunner (https://github.com/BattleBit-Community-Servers/BattleBitAPIRunner) Please re-evaluate.

I have imported both into ptero and tested - they work as expected

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants