Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard ipAddresses cache if wings is offline + Switch to Select #862

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

RMartinOscar
Copy link
Contributor

No description provided.

@notAreYouScared
Copy link
Member

Until we can figure out why wings fails to report ips some times. This can stay

@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
@RMartinOscar RMartinOscar reopened this Jan 5, 2025
@RMartinOscar RMartinOscar changed the title Change Allocation IP to Select Discard ipAddresses cache if wings is offline + Switch to Select Jan 5, 2025
@alexevladgabriel alexevladgabriel self-requested a review January 5, 2025 23:04
Copy link
Contributor

@alexevladgabriel alexevladgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/Models/Node.php Outdated Show resolved Hide resolved
app/Models/Node.php Outdated Show resolved Hide resolved
@RMartinOscar RMartinOscar merged commit ae44584 into pelican-dev:main Jan 6, 2025
15 checks passed
@RMartinOscar RMartinOscar deleted the fix/AllocationIPSelect branch January 6, 2025 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants