Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OAuth Settings to Settings #839

Merged
merged 7 commits into from
Jan 4, 2025
Merged

Add OAuth Settings to Settings #839

merged 7 commits into from
Jan 4, 2025

Conversation

notAreYouScared
Copy link
Member

Attempt 2?

@notAreYouScared notAreYouScared self-assigned this Dec 25, 2024
Boy132
Boy132 previously requested changes Dec 28, 2024
View reviewed changes
Copy link
Member

@Boy132 Boy132 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about the changes on Discord.

@RMartinOscar RMartinOscar mentioned this pull request Dec 29, 2024
Closed
5 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
@notAreYouScared notAreYouScared dismissed Boy132’s stale review January 4, 2025 17:31

Lance looked at both and said mine was fine for now, we can always change it down the road if customer oauth providers are added.

@notAreYouScared notAreYouScared merged commit 17805f6 into main Jan 4, 2025
17 checks passed
@notAreYouScared notAreYouScared deleted the charles/oauth-settings branch January 4, 2025 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lancepioch lancepioch lancepioch approved these changes

@Boy132 Boy132 Boy132 left review comments

Assignees

@notAreYouScared notAreYouScared

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notAreYouScared @lancepioch @Boy132