Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page #486

Merged
merged 27 commits into from
Jul 29, 2024
Merged

Settings page #486

merged 27 commits into from
Jul 29, 2024

Conversation

Boy132
Copy link
Member

@Boy132 Boy132 commented Jul 16, 2024

Adds a simple Settings page. Settings are directly written to the .env file.
The old admin settings stuff is removed.

This supersedes #259.

grafik
grafik
grafik
grafik
grafik

@Boy132 Boy132 requested a review from lancepioch July 16, 2024 09:01
@RMartinOscar
Copy link
Contributor

Why fully removing the APP_ENVIRONMENT_ONLY instead of setting the default to false ?
I find it very useful for troubleshooting

@Boy132
Copy link
Member Author

Boy132 commented Jul 16, 2024

Why fully removing the APP_ENVIRONMENT_ONLY instead of setting the default to false ? I find it very useful for troubleshooting

Because it's no longer doing anything. Settings are directly written to the .env file.

@RMartinOscar
Copy link
Contributor

RMartinOscar commented Jul 16, 2024

Why fully removing the APP_ENVIRONMENT_ONLY instead of setting the default to false ? I find it very useful for troubleshooting

Because it's no longer doing anything. Settings are directly written to the .env file.

Mybad thought it was still saved in the settings table of the db.
We should maybe add a migration that takes what's importable from the db and put them in env so we don't have to reconfig everything when updating the panel or migrating from ptero

@notAreYouScared
Copy link
Member

I feel this is a good start, overtime i can add everything we have an env value for.

@notAreYouScared
Copy link
Member

I feel this is good enough in its current state to be added, More settings can be added along the way.

@Boy132 Boy132 merged commit a58e159 into pelican-dev:main Jul 29, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
@Boy132 Boy132 deleted the feature/settings branch July 29, 2024 10:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants