Use handle instead of toggle & use const isnstead of string

pelican-dev · Jan 6, 2025 · b5bcdc7 · b5bcdc7
1 parent 2525af8
commit b5bcdc7
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php b/app/Filament/Admin/Resources/ServerResource/Pages/EditServer.php
@@ -792,7 +792,7 @@ public function form(Form $form): Form
                                                         ->color('warning')
                                                         ->hidden(fn (Server $server) => $server->isSuspended())
                                                         ->action(function (SuspensionService $suspensionService, Server $server) {
-                                                            $suspensionService->toggle($server, 'suspend');
+                                                            $suspensionService->handle($server, SuspensionService::ACTION_SUSPEND);
                                                             Notification::make()->success()->title('Server Suspended!')->send();
 
                                                             $this->refreshFormData(['status', 'docker']);
@@ -802,7 +802,7 @@ public function form(Form $form): Form
                                                         ->color('success')
                                                         ->hidden(fn (Server $server) => !$server->isSuspended())
                                                         ->action(function (SuspensionService $suspensionService, Server $server) {
-                                                            $suspensionService->toggle($server, 'unsuspend');
+                                                            $suspensionService->handle($server, SuspensionService::ACTION_UNSUSPEND);
                                                             Notification::make()->success()->title('Server Unsuspended!')->send();
 
                                                             $this->refreshFormData(['status', 'docker']);

diff --git a/app/Filament/Admin/Resources/UserResource/RelationManagers/ServersRelationManager.php b/app/Filament/Admin/Resources/UserResource/RelationManagers/ServersRelationManager.php
@@ -34,7 +34,7 @@ public function table(Table $table): Table
                     ->color('warning')
                     ->action(function (SuspensionService $suspensionService) use ($user) {
                         foreach ($user->servers()->whereNot('status', ServerState::Suspended)->get() as $server) {
-                            $suspensionService->toggle($server);
+                            $suspensionService->handle($server);
                         }
                     }),
                 Actions\Action::make('toggleUnsuspend')
@@ -43,7 +43,7 @@ public function table(Table $table): Table
                     ->color('primary')
                     ->action(function (SuspensionService $suspensionService) use ($user) {
                         foreach ($user->servers()->where('status', ServerState::Suspended)->get() as $server) {
-                            $suspensionService->toggle($server, SuspensionService::ACTION_UNSUSPEND);
+                            $suspensionService->handle($server, SuspensionService::ACTION_UNSUSPEND);
                         }
                     }),
             ])

diff --git a/app/Http/Controllers/Api/Application/Servers/ServerManagementController.php b/app/Http/Controllers/Api/Application/Servers/ServerManagementController.php
@@ -32,7 +32,7 @@ public function __construct(
      */
     public function suspend(ServerWriteRequest $request, Server $server): Response
     {
-        $this->suspensionService->toggle($server);
+        $this->suspensionService->handle($server);
 
         return $this->returnNoContent();
     }
@@ -44,7 +44,7 @@ public function suspend(ServerWriteRequest $request, Server $server): Response
      */
     public function unsuspend(ServerWriteRequest $request, Server $server): Response
     {
-        $this->suspensionService->toggle($server, SuspensionService::ACTION_UNSUSPEND);
+        $this->suspensionService->handle($server, SuspensionService::ACTION_UNSUSPEND);
 
         return $this->returnNoContent();
     }

diff --git a/app/Services/Servers/SuspensionService.php b/app/Services/Servers/SuspensionService.php
@@ -27,7 +27,7 @@ public function __construct(
      *
      * @throws \Throwable
      */
-    public function toggle(Server $server, string $action = self::ACTION_SUSPEND): void
+    public function handle(Server $server, string $action = self::ACTION_SUSPEND): void
     {
         Assert::oneOf($action, [self::ACTION_SUSPEND, self::ACTION_UNSUSPEND]);
 

diff --git a/tests/Integration/Services/Servers/SuspensionServiceTest.php b/tests/Integration/Services/Servers/SuspensionServiceTest.php
@@ -29,11 +29,11 @@ public function testServerIsSuspendedAndUnsuspended(): void
 
         $this->repository->expects('setServer->sync')->twice()->andReturnSelf();
 
-        $this->getService()->toggle($server);
+        $this->getService()->handle($server);
 
         $this->assertTrue($server->refresh()->isSuspended());
 
-        $this->getService()->toggle($server, SuspensionService::ACTION_UNSUSPEND);
+        $this->getService()->handle($server, SuspensionService::ACTION_UNSUSPEND);
 
         $this->assertFalse($server->refresh()->isSuspended());
     }
@@ -42,13 +42,13 @@ public function testNoActionIsTakenIfSuspensionStatusIsUnchanged(): void
     {
         $server = $this->createServerModel();
 
-        $this->getService()->toggle($server, SuspensionService::ACTION_UNSUSPEND);
+        $this->getService()->handle($server, SuspensionService::ACTION_UNSUSPEND);
 
         $server->refresh();
         $this->assertFalse($server->isSuspended());
 
         $server->update(['status' => ServerState::Suspended]);
-        $this->getService()->toggle($server);
+        $this->getService()->handle($server);
 
         $server->refresh();
         $this->assertTrue($server->isSuspended());
@@ -61,7 +61,7 @@ public function testExceptionIsThrownIfInvalidActionsArePassed(): void
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('Expected one of: "suspend", "unsuspend". Got: "foo"');
 
-        $this->getService()->toggle($server, 'foo');
+        $this->getService()->handle($server, 'foo');
     }
 
     private function getService(): SuspensionService