Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I have added the ability to optionally ingest shapes
actually returning shape geometry from elasticsearch depends on other changes in
schema
andapi
; those pull requests are also being created, and the entire stack can be seen here: https://github.com/lokkju/pelias-us-shape-autocompleteHere's the reason for this change 🚀
admin region boundary display has been a long desired feature, but it should be optional as it increases index size. This changeset enables the optional ingestion of boundaries from whosonfirst data into the pelias-schema shape field.
Here's what actually got changed 👏
importShapes
option to the config, defaulting to falseHere's how others can test the changes 👀
Unit tests were added, and the full stack of changesets can be tried from the above repository.