added schema validation and updated lint configuration #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trescube
commented
Dec 21, 2016
trescube
commented
- use Joi for sub-config schema validation, incorporated into download_data.js and import.js
- copied .jslintrc from latest api
orangejulius
requested changes
Dec 21, 2016
| console.error('Inability to parse JSON usually means that WOF has been cloned ' + | ||
| 'without using git-lfs, please see instructions here: ' + | ||
| 'https://github.com/whosonfirst/whosonfirst-data#git-and-large-files'); | ||
| next(null, {}); | ||
| next(parse_err); | ||
| } |
There was a problem hiding this comment.
this all changes the behavior here. It's actually a change we want to make, but maybe it should be in a separate PR?
There was a problem hiding this comment.
So make lint updates in a separate PR?
There was a problem hiding this comment.
No, lint updates are fine to change. But the changes to this file change the behavior, because any error will now stop the stream. We want to do that (As mentioned in this comment), but it seems better to make that change in its own PR.
There was a problem hiding this comment.
Lint is complaining about the long lines, that's why I changed them. I'll disable that in .jslintrc for now.
use Joi for sub-config schema validation, incorporated into download_data.js and import.js copied .jslintrc from latest api
trescube
force-pushed
the
add-joi-config-validation
branch
from
6d8bdd4
to
0d549dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.