Add "«", "»" to blacklist characters list #496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
We faced an issue that our Pelias instance couldn't find
ТРЦ «Respublika Park»
(https://www.openstreetmap.org/way/293888317) via queries which don't contain "«", "»" symbols(e.g. I expectRespublika Park
to be almost perfect match for this place). After some experimentations I narrowed it down to the fact that Pelias's ElasticSearch schema doesn't consider these symbols as blacklist ones, i.e. it becomes part of token (now we get«Respublika
andPark»
as separate tokens). So I propose to add it to list of blacklisted characters to fix the issue. Such symbols are quite popular in some regions, see this wiki article https://en.wikipedia.org/wiki/GuillemetHere's the reason for this change 🚀
"«", "»" symbols are quite popular delimiters in some languages.
Here's what actually got changed 👏
Added "«", "»" symbols to blacklist characters list
Here's how others can test the changes 👀
I updated tests + it can be tested manually via bootstrapping ES instance.