enable docvalues for source_id field #482
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft PR to test the effect of enabling
docvalues
for thesource_id
field.this is motivated by the discussion in pelias/api#1608
it is hoped that this field can be used as an additional sorting criteria in order to make the ordering of results with the same
_score
value more deterministic, and therefore make testing more stable and predictable.my concerns with this change are:
docvalues
are loaded)the
source_id
values are almost entirely unique and non-sequential, so I'd expect to see poor compression.although.. these concerns are hopefully unwarranted, we might want to check those before merging this.