Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no linting or syntax checking enabled for this repo, which means that there are variable levels of code quality throughout the codebase.
There are a few options to set it up, all of which are fairly painful tasks:
jshint
+precommit-hook
setupeslint
standardjs
which also uses theeslint
rules (AFAIK)I opted for the third option for a couple reasons:
standard --fix
will automatically reformat a bunch of the code, saving time and preventing errorstandardjs
because it means everyone writes the same style.I started doing the refactor and had to give up after ~30mins because it's such a horrible task, I'm going to leave this PR open to be finished another day.
I'd also be happy if this PR were superseded by another quicker method of getting linting + syntax checking enabled for this repo.
To view the remaining errors (~300):