Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting + syntax checking #458

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

linting + syntax checking #458

wants to merge 1 commit into from

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented Aug 4, 2020

There is currently no linting or syntax checking enabled for this repo, which means that there are variable levels of code quality throughout the codebase.

There are a few options to set it up, all of which are fairly painful tasks:

  • configure our standard jshint + precommit-hook setup
  • configure something more modern like eslint
  • use standardjs which also uses the eslint rules (AFAIK)

I opted for the third option for a couple reasons:

  • standard --fix will automatically reformat a bunch of the code, saving time and preventing error
  • while I'm not 100% in love with all the decisions, I like standardjs because it means everyone writes the same style.

I started doing the refactor and had to give up after ~30mins because it's such a horrible task, I'm going to leave this PR open to be finished another day.

I'd also be happy if this PR were superseded by another quicker method of getting linting + syntax checking enabled for this repo.

To view the remaining errors (~300):

git commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant