Support testing against ES5 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains all the changes necessary to run tests against ES5 or ES2. Because we are still working through issues to support ES5, those tests are allowed to fail in TravisCI.
orangejulius
force-pushed
the
test_against_es5
branch
from
f60a6a8
to
96e4131
Compare
This was referenced Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all the changes necessary to run tests against ES5 or ES2.
Because we are still working through issues to support ES5, those tests
are allowed to fail in TravisCI.
As a subset of #323, I'd propose we merge this immediately, so that any other changes to improve result quality in Elasticsearch 5 can be merged separately.