update schema mappings to include all current layers #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the schema allows creating new
_types
dynamically using the_default_
API, we have been using this feature when introducing new layers such asstreet
.there is, however, an advantage to creating the
_type
explicitly. Elasticsearch will error instead of returning 0 results for any_type
that is requested but is not present in the_mapping
.by creating all known layers at schema creating time, we can avoid these sort of errors, this is less relevant for full-planet, all-layer builds and more relevant to smaller builds which only import a subset of layers.
I haven't seen a bug report for it, but I imagine that if someone only imported WOF and requested something from a combination of
street
orregion
layers, a 500 level error would be produced rather than simply returning matches from theregion
layer.