Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OkHttp3 & Retrofit2 #55

Merged
merged 3 commits into from
Jan 3, 2017
Merged

OkHttp3 & Retrofit2 #55

merged 3 commits into from
Jan 3, 2017

Conversation

ecgreb
Copy link
Collaborator

@ecgreb ecgreb commented Dec 28, 2016

Overview

Upgrades networking stack to okhttp3 and retrofit2

Proposed Changes

  • OkHttp 3.5.0
  • Retrofit 2.1.0
  • Bumps version code to 1.1.0-SNAPSHOT
  • Replaces Retrofit request interceptor with OkHttp network interceptor for attaching custom headers and query params.

@ecgreb ecgreb mentioned this pull request Dec 28, 2016
Merged
@ecgreb ecgreb requested a review from sarahsnow1 December 28, 2016 23:13
@ecgreb
Copy link
Collaborator Author

ecgreb commented Dec 28, 2016

Would like to get thoughts from @tallytalwar on this too since he just completed the OkHttp3 upgrade in Tangram ES.

@ecgreb ecgreb requested a review from tallytalwar December 29, 2016 16:44
tallytalwar
tallytalwar approved these changes Dec 29, 2016
View reviewed changes
Copy link
Collaborator

@tallytalwar tallytalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Not familiar with usage of retrofit, so had to read on it.

@ecgreb
Copy link
Collaborator Author

ecgreb commented Dec 29, 2016

Thanks @tallytalwar.

Yeah it turns out the way Retrofit and OkHttp interact changed quite a bit when upgrading. Especially around sync/asyc calls, request interceptors, and logging.

@ecgreb ecgreb mentioned this pull request Dec 29, 2016
Closed
@sarahsnow1 sarahsnow1 merged commit 44a08c5 into master Jan 3, 2017
@sarahsnow1 sarahsnow1 deleted the okhttp3 branch January 3, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahsnow1 sarahsnow1 sarahsnow1 approved these changes

@tallytalwar tallytalwar tallytalwar approved these changes

Assignees

@sarahsnow1 sarahsnow1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecgreb @tallytalwar @sarahsnow1