Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of "Empire State Building" #84

Merged
merged 1 commit into from
Mar 17, 2020
Merged

fix parsing of "Empire State Building" #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion resources/pelias/dictionaries/libpostal/en/place_names.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
temple
cathedral
stop
!dist
!dist
building
3 changes: 2 additions & 1 deletion resources/pelias/dictionaries/whosonfirst/locality/name:eng_x_preferred.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ sf
!deli
!us
!germany
!empire
# remove any localities which share a name with a US state
!alabama
!alaska
Expand Down Expand Up @@ -62,4 +63,4 @@ sf
#!washington
!west virginia
!wisconsin
!wyoming
!wyoming
5 changes: 5 additions & 0 deletions test/venue.usa.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ const testcase = (test, common) => {
{ place: 'Air & Space Museum' },
{ locality: 'Washington' }, { region: 'DC' }
])

assert('Empire State Building NYC', [
{ place: 'Empire State Building' },
{ locality: 'NYC' }
])
}

module.exports.all = (tape, common) => {
Expand Down