feat(dictionaries): dictionary updates (#22)

pelias · May 16, 2019 · 93cd613 · 93cd613
1 parent 152bad5
commit 93cd613
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/classifier/CompoundStreetClassifier.js b/classifier/CompoundStreetClassifier.js
@@ -15,9 +15,6 @@ class CompoundStreetClassifier extends WordClassifier {
       // this removes suffixes such as 'r.' which can be ambiguous
       minlength: 3
     })
-
-    // whitelist
-    this.suffixes.park = true
   }
 
   each (span) {

diff --git a/classifier/CompoundStreetClassifier.test.js b/classifier/CompoundStreetClassifier.test.js
@@ -25,14 +25,14 @@ module.exports.tests.contains_numerals = (test) => {
 module.exports.tests.german_compound = (test) => {
   let valid = [
     'teststraße', 'teststrasse', 'teststr.',
+    'teststr', 'grolmanstr',
     'testallee',
     'testweg',
     'testplatz',
     'testpl.'
   ]
 
   let invalid = [
-    'teststr',
     'testal',
     'testw', 'testw.'
   ]

diff --git a/resources/pelias/dictionaries/libpostal/de/concatenated_suffixes_separable.txt b/resources/pelias/dictionaries/libpostal/de/concatenated_suffixes_separable.txt
@@ -0,0 +1,2 @@
+str
+park
diff --git a/resources/pelias/dictionaries/whosonfirst/locality/name:eng_x_preferred.txt b/resources/pelias/dictionaries/whosonfirst/locality/name:eng_x_preferred.txt
@@ -6,6 +6,8 @@ sf
 !italy
 !college
 !university
+!airport
+!deli
 # remove any localities which share a name with a US state
 !alabama
 !alaska

diff --git a/test/intersection.test.js b/test/intersection.test.js
@@ -94,6 +94,14 @@ const testcase = (test, common) => {
     [{ street: 'SW 6th' }, { street: 'Pine' }]
   ])
 
+  // Should not detect this as an intersection
+  // assert('University of Hawaii at Hilo', [
+  //   [{ street: 'SW 6th' }, { street: 'Pine' }]
+  // ])
+  // assert('national air and space museum', [
+  //   [{ street: 'SW 6th' }, { street: 'Pine' }]
+  // ])
+
   // Trimet syntax
   // assert('9,Lambert', [
   //   [{ street: '9' }, { street: 'Lambert' }]