Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for rare cases where country labels are blank #47

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

missinglink
Copy link
Member

@missinglink missinglink commented Jun 9, 2021

This issue was closed today pelias/api#720 but I noticed when clicking the link that we still have a rare labelling issue.

In the case where the record is a country and it has no admin info, we currently produce no label 😱

Screenshot 2021-06-09 at 12 16 28

It's a very rare case, in fact this Geonames Philippines doc might be the only one, but this PR fixes it.

@missinglink missinglink requested a review from orangejulius June 9, 2021 10:19
Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should have fixed this years ago :)

Looks like its easy fortunately, and clearly no one uses sources=geonames (thankfully), or we'd have heard about this more often.

@orangejulius orangejulius merged commit a1374a9 into master Jun 9, 2021
@orangejulius orangejulius deleted the empty_country_labels branch June 9, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants