Skip to content

Commit

Permalink
CI: move away from an Ubuntu version variable in GH Actions
Browse files Browse the repository at this point in the history
This doesn't really save us much effort and breaks CI on forks.

Connects pelias/pelias#951
  • Loading branch information
orangejulius committed Nov 25, 2024
1 parent 8906d74 commit 1d1e309
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
strategy:
matrix:
os:
- ${{ vars.UBUNTU_VERSION }}
- ubuntu-22.04
node-version:
- 12.x
- 14.x
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
npm-publish:
needs: unit-tests
if: github.ref == 'refs/heads/master' && needs.unit-tests.result == 'success'
runs-on: ${{ vars.UBUNTU_VERSION }}
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Install Node.js
Expand All @@ -26,7 +26,7 @@ jobs:
# note: github actions won't run a job if you don't call one of the status check functions, so `always()` is called since it evalutes to `true`
if: ${{ always() && needs.unit-tests.result == 'success' && (needs.npm-publish.result == 'success' || needs.npm-publish.result == 'skipped') }}
needs: [unit-tests, npm-publish]
runs-on: ${{ vars.UBUNTU_VERSION }}
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Build Docker images
Expand Down

0 comments on commit 1d1e309

Please sign in to comment.