Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple countryCodes #360

Open
mihneadb opened this issue May 7, 2019 · 1 comment · May be fixed by #408
Open

Support multiple countryCodes #360

mihneadb opened this issue May 7, 2019 · 1 comment · May be fixed by #408

Comments

@mihneadb
Copy link

mihneadb commented May 7, 2019

Right now one has to choose between either a specific country or ALL for countryCode. Would be nice to support a list of codes, like what the other configs do.
@missinglink
Copy link
Member

👍 sounds good, we'd be happy to accept a PR which allows an array of country codes.
It would need to be backwards compatible so that either a string or an array of strings was allowed.

For now, the workaround is to run the download and import steps once per countrycode

arne-cl added a commit to arne-cl/geonames that referenced this issue Jun 24, 2019
@arne-cl
support multiple country codes. closes pelias#360
93fac62
arnesetzer pushed a commit to arnesetzer/geonames that referenced this issue Jan 16, 2023
@arne-cl @arnesetzer
support multiple country codes. closes pelias#360
9fb3928
@arnesetzer arnesetzer linked a pull request Jan 16, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiple countryCodes arnesetzer/geonames
2 participants
@mihneadb @missinglink