feat: Add default index names for API and schema #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backwards compatible config that adds configuration defaults for Elasticsearch index names for both the API and schema (which is also intended to be used by the importers). Connects pelias/api#334
orangejulius
force-pushed
the
configurable_index_name
branch
from
aa4869b
to
2c2284d
Compare
|
|
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of pelias/api#334, we want to be able to configure the Elasticsearch index name that is used by the API, and separately, the importers.
This is a backwards compatible config that adds configuration defaults
for Elasticsearch index names for both the API and schema (which is also
intended to be used by the importers).
While this change by itself doesn't affect anything, it is what will determine what the config parameter names are for changing which Elasticsearch index to use, so if there is anything confusing about the current names, this is the best time to change them.
Connects pelias/api#334