Remove unused typeName which was deprecated in es7, forbidden in es8
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In es6 it was recommended to be "_doc". In es7 it was required to be "_doc". In es8 it's not allowed at all. See more: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html
michaelkirk
changed the title
typeName which typeName which was deprecated in es7, forbidden in es8
6 tasks
|
Thanks for the PR, this officially drops support for elasticsearch v6 so that v8 can now be supported.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the reason for this change 🚀
I'd like Pelias to run on elasticsearch 8 some day. This is a step towards that.
Pelias does not support es6. Mapping types were first deprecated in es6 and optional with es7, but are now breaking with my es8 tests.
Here's what actually got changed 👏
I removed
typeNamefrom the default config.In es6 it was recommended to be "_doc".
In es7 it was optional, but if specified it was required to be "_doc".
In es8 it's not allowed at all.
See more:
https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html
Here's how others can test the changes 👀
I ran the existing tests and have successfully utilized this in the context of pelias/schema#490