Added postalcode rules for node-postal call and fallbacks #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
dianashk
reviewed
Sep 7, 2017
There was a problem hiding this comment.
Thank you so much for your ✨ contribution ✨ ! We really appreciate it. ❤️
This looks great! I tested it locally and it seems to work as advertised. 👏 🌮
It would be really helpful if you could add one or two tests to show the intention behind the new code. We already have a test file for these modules so hopefully, there are existing tests that can be borrowed from.
Let us know if you don't have the bandwidth to get to those and we'll take care of adding them on our own once this is merged.
Thank you, again, for your contribution!
|
Just added some tests (and added a couple of postcode parameters to some other tests) which hopefully will cover it :) |
dianashk
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated searching to take into account postcodes in structured search and to use the fallback scoring if postcode is passed with a country.
In relation to issue #973