Short sources gid #574
Merged
Short sources gid #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
|
|
||
| if (!_.includes(type_mapping.layers, layer)) { | ||
| messages.errors.push( targetError(layer, type_mapping.layers) ); | ||
| return; | ||
| } | ||
| //converts the shortened source names to the full name |
There was a problem hiding this comment.
You could remove the if statement here, since the source_mapping supports either the short or long name
There was a problem hiding this comment.
A nice reason to do that is it keeps more knowledge of what the "real" source name is in the type_mapping file, rather than here
|
As mentioned by @dianashk it would be great to have acceptance tests for this. They can go in the place.json test case file |
Removed an extraneous if statement
|
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully) will allows someone to search using a gid typing in the short name of a source, e.g oa:venue:123456 as opposed to openaddresses:venue:123456
Fixes #441