simplified dedupe + preserve order #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
force-pushed
the
simplified_dedupe_preserve_order
branch
from
ee7998e
to
8c70f8f
Compare
|
Cool, this fixes the example I had in mind, will run it through the full test suite to see if it looks good overall. |
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Mar 3, 2022
This test case came out of evaluating pelias/api#1607. It passes with the current API master branch, fails with pelias/api#1607, but passes with pelias/api#1612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an extension to #1607 which preserves ordering of synonymous records (ie. the lower ordinal position is inherited by the superior record).