Update pelias-parser to 1.52.0 #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
changed the title
|
Looking over the release notes, most of the new feature work targeted unit numbers and unit types. |
|
There are just a couple improvements to autocomplete from this PR, but they are pretty good, especially for venue queries:
|
orangejulius
force-pushed
the
pelias-parser-1.52.0
branch
3 times, most recently
from
70463ea
to
6cdf31b
Compare
Joxit
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Full changelog:
- fix parsing of "Empire State Building"
- add -kanal as seperable street suffix
- improved street name parsing (for intersections)
- supports for central European street names
- supports for unit (unit/apt/lot/#..) & included in parser responses
- allow middle names
- Brazilian postcodes format
- improved parssing of ordinal prefixes
- venue classification (replace
place) - improved USA highway name parsing
- improved parsing of directional prefixes/suffixes
orangejulius
force-pushed
the
pelias-parser-1.52.0
branch
from
6cdf31b
to
5a18a16
Compare
There were remarkably few changes required to the unit tests in API with this upgrade.
orangejulius
force-pushed
the
pelias-parser-1.52.0
branch
from
5a18a16
to
5134090
Compare
missinglink
approved these changes
Jun 30, 2020
|
Just did some final testing on this, we're seeing good improvements across the board with this upgrade. Definitely good stuff :) |
orangejulius
added a commit
to pelias/acceptance-tests
that referenced
this pull request
Jun 30, 2020
It passes since pelias/api#1452 and pelias/parser#84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were remarkably few changes required to the unit tests in API with this upgrade.