revert ccb9bc8180535bc5a1e55a523843a53334bc1c07 #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest waiting a calendar month before merging |
|
For reference, builds created at/after docker |
|
Makes sense. A month might even be longer than needed. But holding off a little while seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit
ccb9bc8180535bc5a1e55a523843a53334bc1c07I just merged #1259 because it's been reviewed and tested.
It's probably a better idea to leave some time between merging pelias/schema#347 and the API PR in order to allow users to catch up.
The potential issue I'm trying to avoid with this PR is that when users with older indices upgrade to a new
pelias/apidocker image they will presumably have errors when trying to use autocomplete due to the ngrams indices being missing.