Issue #124. #135
Merged
Issue #124. #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to clean up the code that converts Artifactory strings to numbers accepted in Prometheus.
KacperPerschke
force-pushed
the
num_conv_arti_to_prom
branch
from
2221844
to
ea19304
Compare
|
|
perfect @KacperPerschke. Need to do a few comparison but we can get the canary out to try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to clean up systematize the code that converts Artifactory strings to numbers accepted in Prometheus.
removeCommastoconvNumArtiToPromshould be deeply investigated.percentagebe the solution to artifactory_storage_filestore_free_bytes calculating from cache #126?