Skip to content

Commit

Permalink
Sped up Element._sort (#104103)
Browse files Browse the repository at this point in the history
  • Loading branch information
gaaclarke authored May 23, 2022
1 parent ec20ea8 commit 41c6063
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions packages/flutter/lib/src/widgets/framework.dart
Original file line number Diff line number Diff line change
Expand Up @@ -3191,15 +3191,21 @@ abstract class Element extends DiagnosticableTree implements BuildContext {
}
late int _depth;

/// Returns result < 0 when [a] < [b], result == 0 when [a] == [b], result > 0
/// when [a] > [b].
static int _sort(Element a, Element b) {
if (a.depth < b.depth)
return -1;
if (b.depth < a.depth)
return 1;
if (b.dirty && !a.dirty)
return -1;
if (a.dirty && !b.dirty)
return 1;
final int diff = a.depth - b.depth;
// If depths are not equal, return the difference.
if (diff != 0) {
return diff;
}
// If the `dirty` values are not equal, sort with non-dirty elements being
// less than dirty elements.
final bool isBDirty = b.dirty;
if (a.dirty != isBDirty) {
return isBDirty ? -1 : 1;
}
// Otherwise, `depth`s and `dirty`s are equal.
return 0;
}

Expand Down

0 comments on commit 41c6063

Please sign in to comment.