refactored sdk to use viem #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
theKosmoss
reviewed
Dec 9, 2024
src/multipass.ts
Outdated
| walletClient: WalletClient; | ||
| }) { | ||
| const artifact = getArtifact(chainName, "Multipass"); | ||
| this.chainId = chainName; |
There was a problem hiding this comment.
this is not correct chainName: SupportedChains; can't be set to chainId. later or there is problem to convert chainName to int
peersky
merged commit 39eca72
into
40-add-support-to-interact-with-010-rankify-interfaces
peersky
added a commit
that referenced
this pull request
Dec 19, 2024
* added 0.10 rankify contracts basic support * updated index file * moved rank token methods to separate class * refactored sdk to use viem (#48) * build suceeds * added prebuild step to copy and use abi's within srcs * fix wrong imports * update prebuild script * update multipass class to use chain ID as a number --------- Co-authored-by: theKosmoss <[email protected]> * Peersky/40 add support 010 rankify/with viem (#49) * build suceeds * added prebuild step to copy and use abi's within srcs * fix wrong imports * generate chain id mapping to supported chains path during sdk build * Refactored sdk to accept chainId instead of chain * made linter to highlight more issues and fixed those * added jest for TDD * multipass unit test * updated ci cd * upd ci * added tests to player, fixed bug * validate address in distributor constructor * multipass constructor tweaks * added abi files to index & generator * export abis as object * reexport abis * fix dist import require paths * Revert "fix dist import require paths" This reverts commit cf816da. * modified build scipt instead * up ci * upd MAO distributor class getter namings * updated generation scripts and decoupled multipass in base and registrar classes * added block range for getEvents * tests mock deployments, removed console logs * remove console logs * happy linter - happy life * added types node * lockfile * add readme and setup local dev script * env sertup process * fix bug * docstrings & readme upd * changeset * upodate docs generation * No need to source env here. Sourcing is inside script --------- Co-authored-by: theKosmoss <[email protected]>
peersky
added a commit
that referenced
this pull request
Dec 19, 2024
* added 0.10 rankify contracts basic support * updated index file * moved rank token methods to separate class * refactored sdk to use viem (#48) * build suceeds * added prebuild step to copy and use abi's within srcs * fix wrong imports * update prebuild script * update multipass class to use chain ID as a number --------- Co-authored-by: theKosmoss <[email protected]> * Peersky/40 add support 010 rankify/with viem (#49) * build suceeds * added prebuild step to copy and use abi's within srcs * fix wrong imports * generate chain id mapping to supported chains path during sdk build * Refactored sdk to accept chainId instead of chain * made linter to highlight more issues and fixed those * added jest for TDD * multipass unit test * updated ci cd * upd ci * added tests to player, fixed bug * validate address in distributor constructor * multipass constructor tweaks * added abi files to index & generator * export abis as object * reexport abis * fix dist import require paths * Revert "fix dist import require paths" This reverts commit cf816da. * modified build scipt instead * up ci * upd MAO distributor class getter namings * updated generation scripts and decoupled multipass in base and registrar classes * added block range for getEvents * tests mock deployments, removed console logs * remove console logs * happy linter - happy life * added types node * lockfile * add readme and setup local dev script * env sertup process * fix bug * docstrings & readme upd * changeset * upodate docs generation * wip * wip * TDD game master * updates for monitor --------- Co-authored-by: theKosmoss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.